implement adaptive navigation, target sdk 35 and edge-to-edge, fill nav suite item when selected, and don't set transitions to null when trying to override + dependency updates and add/update .idea xmls
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soupslurpr
changed the title
xmlsxmls
soupslurpr
force-pushed
the
adaptive-navigation-+-dependency-updates-+-let-default-transitions-be-overriden
branch
from
1b44911 to
81e0c75
Compare
was previously set to "Android API 34, extension level 7 Platform" which I'm not sure is valid. the IDE automatically made this change.
… don't set transitions to null when trying to override
soupslurpr
force-pushed
the
adaptive-navigation-+-dependency-updates-+-let-default-transitions-be-overriden
branch
from
81e0c75 to
ef5f688
Compare
|
Merged with verification metadata regenerated. |
soupslurpr
deleted the
adaptive-navigation-+-dependency-updates-+-let-default-transitions-be-overriden
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adaptive navigation + edge-to-edge support
Adaptive navigation allows for a better experience for various window sizes. The animation is also changed appropriately to a vertical sliding animation instead of a horizontal one. The AndroidX library
androidx.compose.material3:material3-adaptive-navigation-suiteis used to implement adaptive navigation.Previously, edge-to-edge wouldn't have even been visible because a bottom navigation bar was always used despite the window size.
Pixel 9 Pro Fold (open)
Before
After
When closed, it automatically switches to a bar instead
Filled icons for selected nav suite items
The selected nav suite item will now switch to a filled icon variant when available. The filled icon is only available for the Community and Donate icons.
Before
After