Skip to content

Commit

Permalink
Implement new abstraction for query params usage.
Browse files Browse the repository at this point in the history
  • Loading branch information
linuspahl committed Jan 8, 2025
1 parent 16f0fcc commit 6dc5ba3
Show file tree
Hide file tree
Showing 9 changed files with 20 additions and 20 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,16 @@
import { renderHook } from 'wrappedTestingLibrary/hooks';
import { OrderedMap } from 'immutable';
import * as React from 'react';
import { useQueryParam } from 'use-query-params';
import { MemoryRouter } from 'react-router-dom';

import { useQueryParam } from 'routing/QueryParams';
import DefaultQueryParamProvider from 'routing/DefaultQueryParamProvider';
import { asMock } from 'helpers/mocking';

import useUrlQueryFilters from './useUrlQueryFilters';

jest.mock('use-query-params', () => ({
...jest.requireActual('use-query-params'),
jest.mock('routing/QueryParams', () => ({
...jest.requireActual('routing/QueryParams'),
useQueryParam: jest.fn(),
}));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
* along with this program. If not, see
* <http://www.mongodb.com/licensing/server-side-public-license>.
*/
import { useQueryParam, ArrayParam } from 'use-query-params';
import { useMemo, useCallback } from 'react';
import { OrderedMap } from 'immutable';

import { useQueryParam, ArrayParam } from 'routing/QueryParams';
import type { UrlQueryFilters } from 'components/common/EntityFilters/types';

const useUrlQueryFilters = (): [UrlQueryFilters, (filters: UrlQueryFilters) => void] => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
*/
import * as React from 'react';
import { useMemo, useCallback } from 'react';
import { useQueryParam, StringParam } from 'use-query-params';
import styled from 'styled-components';

import { useQueryParam, StringParam } from 'routing/QueryParams';
import useTableLayout from 'components/common/EntityDataTable/hooks/useTableLayout';
import usePaginationQueryParameter from 'hooks/usePaginationQueryParameter';
import useUpdateUserLayoutPreferences from 'components/common/EntityDataTable/hooks/useUpdateUserLayoutPreferences';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,17 @@
*/
import React from 'react';
import { render, screen } from 'wrappedTestingLibrary';
import { useQueryParam } from 'use-query-params';

import { useQueryParam } from 'routing/QueryParams';
import type { MigrationState, MigrationStateItem } from 'components/datanode/Types';
import { asMock } from 'helpers/mocking';

import RemoteReindexingMigration from './RemoteReindexingMigration';

import { MIGRATION_STATE } from '../Constants';

jest.mock('use-query-params', () => ({
...jest.requireActual('use-query-params'),
jest.mock('routing/QueryParams', () => ({
...jest.requireActual('routing/QueryParams'),
useQueryParam: jest.fn(),
}));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ import * as React from 'react';
import { useState, useEffect } from 'react';
import styled, { css } from 'styled-components';
import type { ColorVariant } from '@graylog/sawmill';
import { useQueryParam, StringParam } from 'use-query-params';

import { useQueryParam, StringParam } from 'routing/QueryParams';
import { ConfirmDialog } from 'components/common';
import { Alert, BootstrapModalWrapper, Button, Modal } from 'components/bootstrap';
import useSendTelemetry from 'logic/telemetry/useSendTelemetry';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
*/
import * as React from 'react';
import { render, screen, fireEvent, within } from 'wrappedTestingLibrary';
import { useQueryParam } from 'use-query-params';

import { useQueryParam } from 'routing/QueryParams';
import { MockStore } from 'helpers/mocking';
import useParams from 'routing/useParams';
import asMock from 'helpers/mocking/AsMock';
Expand Down Expand Up @@ -80,8 +80,8 @@ jest.mock('components/indices/IndexSetFieldTypeProfiles/hooks/useProfile');
jest.mock('components/indices/IndexSetFieldTypes/hooks/useIndexProfileWithMappingsByField');
jest.mock('components/indices/IndexSetFieldTypeProfiles/hooks/useProfileOptions');

jest.mock('use-query-params', () => ({
...jest.requireActual('use-query-params'),
jest.mock('routing/QueryParams', () => ({
...jest.requireActual('routing/QueryParams'),
useQueryParam: jest.fn(),
}));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
*/
import * as React from 'react';
import { render, screen, fireEvent, within } from 'wrappedTestingLibrary';
import { useQueryParam } from 'use-query-params';

import { useQueryParam } from 'routing/QueryParams';
import { MockStore } from 'helpers/mocking';
import asMock from 'helpers/mocking/AsMock';
import useFetchEntities from 'components/common/PaginatedEntityTable/useFetchEntities';
Expand Down Expand Up @@ -53,8 +53,8 @@ jest.mock('components/common/PaginatedEntityTable/useFetchEntities', () => jest.

jest.mock('components/common/EntityDataTable/hooks/useUserLayoutPreferences');

jest.mock('use-query-params', () => ({
...jest.requireActual('use-query-params'),
jest.mock('routing/QueryParams', () => ({
...jest.requireActual('routing/QueryParams'),
useQueryParam: jest.fn(),
}));

Expand Down
4 changes: 2 additions & 2 deletions graylog2-web-interface/src/routing/QueryParams.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* along with this program. If not, see
* <http://www.mongodb.com/licensing/server-side-public-license>.
*/
import { useQueryParams, useQueryParam, StringParam, NumberParam } from 'use-query-params';
import { useQueryParams, useQueryParam, StringParam, NumberParam, ArrayParam } from 'use-query-params';

const parseNestedObject = (fieldQueryString: string) => {
try {
Expand All @@ -29,4 +29,4 @@ const NestedObjectParam = {
decode: (objectStr: string | null | undefined) => parseNestedObject(objectStr),
};

export { useQueryParams, useQueryParam, StringParam, NumberParam, NestedObjectParam };
export { useQueryParams, useQueryParam, StringParam, NumberParam, NestedObjectParam, ArrayParam };
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
*/
import React from 'react';
import { render, screen } from 'wrappedTestingLibrary';
import { useQueryParam } from 'use-query-params';

import { useQueryParam } from 'routing/QueryParams';
import View from 'views/logic/views/View';
import Search from 'views/logic/search/Search';
import { asMock } from 'helpers/mocking';
Expand All @@ -43,8 +43,8 @@ jest.mock('views/stores/ViewManagementStore', () => ({
},
}));

jest.mock('use-query-params', () => ({
...jest.requireActual('use-query-params'),
jest.mock('routing/QueryParams', () => ({
...jest.requireActual('routing/QueryParams'),
useQueryParam: jest.fn(),
}));

Expand Down

0 comments on commit 6dc5ba3

Please sign in to comment.