Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISW - Input Diagnosis improvements #21337

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

grotlue
Copy link
Contributor

@grotlue grotlue commented Jan 13, 2025

Description

/nocl
closes #21326

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@grotlue grotlue linked an issue Jan 13, 2025 that may be closed by this pull request
7 tasks
@laura-b-g laura-b-g marked this pull request as ready for review February 11, 2025 17:44
…t-diagnosis-improvements

# Conflicts:
#	graylog2-web-interface/src/components/inputs/InputDiagnosis/useInputDiagnosis.ts

@Test
void testMetricsIncludesOnlyTheLast15UpdatesIfNoConstantCounterIncrease() {
for (int i = 0; i < SIZE_FOR_15_MINUTES; i++) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be on the safe side in case of off by 1 errors, I would increase the number of iterations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISW - Input Diagnosis Improvements
4 participants