Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Framework for deprecating pipeline functions #21467

Merged
merged 13 commits into from
Feb 3, 2025
Merged

Conversation

gally47
Copy link
Contributor

@gally47 gally47 commented Jan 28, 2025

Motivation and Context

fixes #19287

Screenshots (if appropriate):

Screenshot 2025-01-29 at 16 19 52

Screenshot 2025-01-29 at 16 20 31

Screenshot 2025-01-29 at 16 21 15

Screenshot 2025-01-29 at 16 21 02

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gally47 gally47 changed the title UI deprecating pipeline functions UI Framework for deprecating pipeline functions Jan 28, 2025
Copy link
Contributor

@ousmaneo ousmaneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

There is a comment inline I added it was caught by the reviewbot too

@@ -116,4 +115,24 @@ describe('RuleBlockDisplay', () => {

expect(screen.getByText('wrong 1, not right 2')).toBeInTheDocument();
});

it('displays errors when existing', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is duplicated.

@ousmaneo ousmaneo self-requested a review January 31, 2025 15:48
@gally47 gally47 merged commit 9af34d1 into master Feb 3, 2025
7 checks passed
@gally47 gally47 deleted the deprecate-remove-field branch February 3, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Framework for deprecating pipeline functions; and deprecate remove_field
2 participants