Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename dwh to dataLake #21507

Merged
merged 8 commits into from
Feb 5, 2025
Merged

rename dwh to dataLake #21507

merged 8 commits into from
Feb 5, 2025

Conversation

ousmaneo
Copy link
Contributor

@ousmaneo ousmaneo commented Jan 31, 2025

This PR rename Datawarehouse with DataLake

/nocl
/jpd Graylog2/graylog-plugin-enterprise#9618

part of https://github.com/Graylog2/graylog-plugin-enterprise/issues/8310

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@ousmaneo ousmaneo marked this pull request as ready for review February 5, 2025 10:18
@ousmaneo ousmaneo requested review from laura-b-g and gally47 February 5, 2025 10:18
@ousmaneo ousmaneo self-assigned this Feb 5, 2025
Copy link
Contributor

@laura-b-g laura-b-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good, but we should reset the input setup feature flag.

@@ -92,7 +92,7 @@ remote_reindex_migration=off
data_warehouse_search=off

# Enable preview of input setup wizard
setup_mode=off
setup_mode=on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
setup_mode=on
setup_mode=on

Should be off by default

@ousmaneo ousmaneo requested a review from laura-b-g February 5, 2025 13:21
@ousmaneo ousmaneo merged commit 3ff77ba into master Feb 5, 2025
7 checks passed
@ousmaneo ousmaneo deleted the dwh-datalake branch February 5, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants