Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds SystemEntity Annotated Caches (6.0) #21530

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Adds SystemEntity Annotated Caches (6.0) #21530

merged 3 commits into from
Feb 6, 2025

Conversation

kingzacko1
Copy link
Contributor

@kingzacko1 kingzacko1 commented Feb 3, 2025 •
edited
Loading

Note: This is a backport of #21439 to 6.0.

Description

  • Adds support for @SystemEntity annotated caches.
  • Adds necessary CacheDto.toBuilder method which did not previously exist in 6.0.

/prd Graylog2/graylog-plugin-enterprise#9647
/nocl see related enterprise PR for CL entry

Motivation and Context

Required in support of Graylog2/graylog-plugin-enterprise#9557

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@kingzacko1 kingzacko1 requested a review from danotorrey February 3, 2025 18:43
danotorrey
danotorrey approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@danotorrey danotorrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on 6.0

@kingzacko1 kingzacko1 merged commit cd6f342 into 6.0 Feb 6, 2025
6 checks passed
@kingzacko1 kingzacko1 deleted the backport-6.0/add-system-cache-entities branch February 6, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danotorrey danotorrey danotorrey approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kingzacko1 @danotorrey