Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add escape character handling to key_value pipeline function (6.0) #21532

Open
wants to merge 2 commits into
base: 6.0
Choose a base branch
from

Conversation

graylog-internal-actions-access[bot]

Note: This is a backport of #21456 to 6.0.

Description

Adds a new use_escape_char parameter that turns on escape character handling for values in the key_value pipeline function.

  • Added this feature as an optional parameter to avoid changing any existing usages of the key_value function.
  • Only works on the outer splitter to allow values to contain escaped delimiter chars - ie, trying to use an escape char in the key doesn't work. Not sure that use case would make sense anyway but open to feedback.

Motivation and Context

closes Graylog2/graylog-plugin-enterprise#9552

How Has This Been Tested?

unit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

* Add use_escape_char param to key_value

* CL and comment clarification

(cherry picked from commit b9ebea9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants