Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Find Query for Index Ranges (make clause for Deflector Indices more explicit, etc.) #21592

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

janheise
Copy link
Contributor

@janheise janheise commented Feb 11, 2025

Description

If you have an index that has messages with a timestamp 1970-01-01 00:00 but that has already been rotated (index_range has begin == 0 and end != 0), it was still found as a valid index for certain operations by the former, now changed query clause that was supposed to only find deflector indices (begin == 0 and end == 0).

This PR fixes the query clause.

I added more tests to reflect those situations.

Also, if you query with a end time before begin time now, an exception is thrown because of an invalid time range.
Screenshot 2025-02-11 at 13 20 09

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

…r indices, runtime exception if time range does not make sense, more tests
@janheise janheise requested review from a team and dennisoelkers February 11, 2025 12:00
@janheise janheise changed the title change query to find indices in range to an equal search for deflecto… Improve Query for Index Ranges (make clause for Deflector Indices more explicit, etc.) Feb 11, 2025
@janheise janheise changed the title Improve Query for Index Ranges (make clause for Deflector Indices more explicit, etc.) Improve Find Query for Index Ranges (make clause for Deflector Indices more explicit, etc.) Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant