GSF.Core: Use anonymous principal when accessing anonymous resources #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenCWills
force-pushed
the
anonymous-principal
branch
from
1a666ce to
0bb37c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The anonymous principal is used at the end of the authentication process if no
SecurityProvideris found to assign toRequest.User. But in the case of anonymous resources, theAuthenticationHandlerallows the user passed in by IIS to leak into the pipeline. Then, inAuthorizeAsync(), theUserHasLogoutRole()function callsWindowsPrincipal.IsInRole()using aWindowsPrincipalrepresenting a nonexistent Windows user on a group calledlogoutthat likely doesn't exist. If we replace theWindowsPrincipalwith the anonymous principal, this should no longer happen.Tested using SE Browser, and this change didn't cause any problems.