Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This k feature #1749

Closed
wants to merge 114 commits into from
Closed

This k feature #1749

wants to merge 114 commits into from

Conversation

twicki
Copy link
Contributor

@twicki twicki commented Nov 26, 2024

Description

Requirements

  • All fixes and/or new features come with corresponding tests.
  • Important design decisions have been documented in the approriate ADR inside the docs/development/ADRs/ folder.

If this PR contains code authored by new contributors please make sure:

  • The PR contains an updated version of the AUTHORS.md file adding the names of all the new contributors.

FlorianDeconinck and others added 30 commits February 13, 2024 14:22
@FlorianDeconinck
Allow frontend to accept K write offset for FORWARD/BACKWARD
b2e46a1
@FlorianDeconinck
Unit test on frontend & code generation
6b9d127
@FlorianDeconinck
lint
1980fe8
@FlorianDeconinck
Remove debug code
6e8c69f
@FlorianDeconinck
Add conditional example simplified from existing column physics
d07a2de
@FlorianDeconinck
Restore ALL_BACKENDS, straighten utest.
e90ec94
@FlorianDeconinck
Verbose DaCeIR coding error when a tasklet variable cannot find the i…
5fff068 
…nput/output memlet link
@FlorianDeconinck
Allow re-use of offset K write ins
2147811
@FlorianDeconinck
Split utest to acknowledge dace:cpu issue
3c6b466
@FlorianDeconinck
Add GPU init/read support in test
239093c 
Restrict the test to the working backends
@FlorianDeconinck
Merge main
52366f1
@FlorianDeconinck
lint
d956202
@FlorianDeconinck
Verbose current dace:X bug around while loop
899a5da
@FlorianDeconinck
lint
b5f112a
@FlorianDeconinck
Allow K offset writes in dace backends
6916121 
Rename connector for better tracking in SDFG
var_offset_fields -> offset_in_K_fields
@FlorianDeconinck
Fix Assign guard on K for I and IJ fields
9803336
@FlorianDeconinck
Merge branch 'main' into cartesian/k_write_offset
4930115
@FlorianDeconinck
Make get_array_library public
5e2a622 
Remove dead comment
@FlorianDeconinck
Merge branch 'main' into cartesian/k_write_offset
7eab8c8
@FlorianDeconinck
Merge branch 'main' into cartesian/k_write_offset
6d2c932
@FlorianDeconinck
Merge branch 'main' into cartesian/k_write_offset
faba6ef
@FlorianDeconinck
Merge branch 'main' into cartesian/k_write_offset
637fcd6
@havogt
Merge branch 'main' into cartesian/k_write_offset
79b2fdc
@FlorianDeconinck
Casting to INT. Add v_in_int = int(v_in_float) op as a base unitary…
cfc8a72 
… op. Deactivate upcaster for thi cast call.
Merge branch 'main' into cartesian/k_write_offset
f51f7ee
Merge branch 'main' into cartesian/k_write_offset
284497a
Merge branch 'main' into cartesian/k_write_offset
2846713
Error out cleanly for gt:gpu and CUDA < 12
8fb7452
Lint
0a376c0
Change cupy call to lower level
a07ea46 
Adapt backend_name to `run` on frontend
Tobias Wicky-Pfund and others added 29 commits October 15, 2024 14:45
Merge commit '90660f5f85c3d4316b6fe6128952476fc7e6cb81' into int_cast…
8514e6b 
…_debug
Merge commit '3078d4728145d189de86557702a0431c6b46d9b7' into int_cast…
4987372 
…_debug
Merge commit 'ad1348f0706ffd61fc05dbf9e15b48bedfedc2d6' into int_cast…
4614a61 
…_debug
update debug backend to support absolute_k
f3a0346
patch florian
b688ef3
Merge commit '2b4be7b389aa94bfbf188f331c796cf97c4ba13c' into int_cast…
844783d 
…_aboslute_k_debug
add parentheses around binary operators
67dab9f
add parentheses around binary operators
ac83df8
Merge branch 'extension_debug_backend' into int_cast_aboslute_k_debug
be711e4
fix debug backend for boolean literals
c41ebd8
@FlorianDeconinck
Native function: f32, f64, round
da8cf7a
apply while patch
f84687d
@FlorianDeconinck
Fix round by using np.rint
b53d3d3 
Fix bad merge
@FlorianDeconinck
Undo keyword change for int cast (for now)
3e96e69
@FlorianDeconinck
i32/i64/f32/f64 cast & type hints
e8ee2c8 
Type hints works in `gtscript.function`
@FlorianDeconinck
Add type hints & convert to gtscript
5638e72 
Add generic return types for Mypy to native function
@FlorianDeconinck
ERF/ERFC native function
0959813
@FlorianDeconinck
Add FieldSlice capacities to numpy backend (LIMITED TO 4D)
fcb3a92
@FlorianDeconinck
Fix bad string refactor
e5f2ffc
@FlorianDeconinck
Fix the previous fix
d75129c
fix how indexation is done to lower dimensional fields
0029d55
remove dead code
eb86855
fix pre-commits
a45065b
@FlorianDeconinck
Merge pull request #8 from twicki/fix_lower_dim_fields_debug
907881f 
fix how indexation is done to lower dimensional fields
add test to debug backend
e999ebd
fix pre-commit
431af6c
ensure int cast for k-accesses to make sure the Field class works w…
f147f7a 
…ell with it
test for field access to describe k-access
a8159e2
add this k
3f93e14
@twicki twicki closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twicki @FlorianDeconinck @havogt