feat[next]: Improve fieldop fusion #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p' into gtir_fuse_as_fieldop
havogt
reviewed
Jan 20, 2025
| @@ -119,9 +175,7 @@ def fuse_as_fieldop( | |||
| pass | |||
| elif cpm.is_call_to(arg, "if_"): | |||
There was a problem hiding this comment.
I was going through the whole file again and got stuck here. Can we briefly discuss
- if it makes the code cleaner, if instead of building an applied field_op we extract the stencil_body and args
- instead of special casing for
ifwe support any function (because onlyifshould be marked as eligible, but if we change the algorithm to mark eligible, we should not have to touch this line)
| target=node.target, | ||
| ) | ||
|
|
||
| def visit_FunCall(self, node: itir.FunCall, **kwargs): |
There was a problem hiding this comment.
Let's rewrite the whole thing together for 2 reasons:
- knowledge sharing
- after it is now (maybe) correct, focus on readability.
|
Can we generate a complicated IR (which we also can easily maintain) as a performance regression test? |
havogt
approved these changes
Feb 6, 2025
I will create this as soon as we have the performance dashboard and I have some spare minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_tuple(as_fieldop(...), as_fieldop(...))calls intoas_fieldop(λ(...) → make_tuple(...))(...)._arg_inline_predicate.as_fieldopargs that use the same arg twice, e.g.as_fieldop(...)(a, b).itir.SetAtare considered.