Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test[cartesian]: Increased coverage for horizontal regions #1807

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

romanc
Copy link
Contributor

@romanc romanc commented Jan 20, 2025

Description

Working on the gt4py/dace bridge showed that code coverage for horizontal regions is low. In particular (code generation) tests for conditionals inside horizontal regions were missing.

Related issue: #720

Requirements

  • All fixes and/or new features come with corresponding tests.
    Added test cases.
  • Important design decisions have been documented in the appropriate ADR inside the docs/development/ADRs/ folder.
    N/A

Working on the gt4py/dace bridge showed that code coverage for
horizontal regions is low. In particular (code generation) tests for
conditionals inside horizontal regions were missing.
Copy link
Contributor

@FlorianDeconinck FlorianDeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@havogt havogt merged commit 758ee03 into GridTools:main Jan 22, 2025
21 checks passed
@romanc romanc deleted the romanc/tests-horizontal-regions branch January 22, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants