fix[dace]: Updating MapFusion #1850
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edopao
approved these changes
Feb 6, 2025
| squeezed_dims: List[int] = [] # These are the dimensions we removed. | ||
| new_inter_shape: List[int] = [] # This is the final shape of the new intermediate. | ||
| for dim, (proposed_dim_size, full_dim_size) in enumerate( | ||
| zip(new_inter_shape_raw, inter_shape) |
There was a problem hiding this comment.
Since inter_shape is cloned from a function input argument and producer_subset is also an input argument, I would suggest:
Suggested change
| zip(new_inter_shape_raw, inter_shape) | |
| zip(new_inter_shape_raw, inter_shape, strict=True) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MapFusion PR in DaCe is still under review.
However, the MapFusion in that PR has evolved, i.e. some bugs were fixed and now GT4Py is also these bugs.
This PR essentially back ports some of the fixes to GT4Py.
Note that this is a temporary solution and as soon as the MapFusion PR has been merged (and parallel map fusion has been introduced) the GT4Py version will go away.