tests[cartesian]: Increase horizontal region test coverage #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A a test case where horizontal regions are used to write to a subset of the field. Note that this is different from `TestHorizontalRegionsCorners` because we have specialized optimizations in place for corners of the cube.
|
The new bridge has one case where this new test fails. That bug is partly why I've seen nan's in the computation of e.g. |
twicki
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A a test case where horizontal regions are used to write to a subset of the field. Note that this is different from
TestHorizontalRegionsCornersbecause we have specialized optimizations in place for corners of the cube.Related issue: #720
Requirements
New tests added
N/A