-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test[next]: enable gpu test for 1d scan on dace backend #1854
Conversation
This reverts commit ff37cd8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I technically have no problem with this changes.
However, there is this link to DaCe issue 1773, that it is still open.
So my question is how did the issue got resolved?
I should have explained it better "this case is no longer an issue". The dace issue is still open. The issue is actually reported on a different test case ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The dace backend did not support the case of scan on a 1D vertical array, when lowered to GPU code. After upgrading the dace package to latest main and adopting the
LoopRegion
construct for the lowering of scan, this case is no longer an issue. This PR just re-enables the scan test case.