Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sniffnet crates.io package for Windows #718

Merged
merged 9 commits into from
Feb 16, 2025
Merged

Fix Sniffnet crates.io package for Windows #718

merged 9 commits into from
Feb 16, 2025

Conversation

GyulyVGC
Copy link
Owner

Fixes #681.

This PR also adds a CI/CD step to the package.yml workflow to check the correctness of the crate before publication.

@GyulyVGC GyulyVGC added bug Something isn't working enhancement New feature, request, or improvement labels Feb 16, 2025
@GyulyVGC GyulyVGC added this to the v1.4.0 milestone Feb 16, 2025
@GyulyVGC GyulyVGC self-assigned this Feb 16, 2025
@GyulyVGC GyulyVGC added the Windows Something related to Windows operating system label Feb 16, 2025
Copy link
Owner Author

@GyulyVGC GyulyVGC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@GyulyVGC
Copy link
Owner Author

It turns out that winres is actually necessary. Reintroduced it in 88da289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature, request, or improvement Windows Something related to Windows operating system
Projects
None yet
1 participant