Fix query replacement for non-spaced queries #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`string.gsub` returns two values: the string with substitutions and the number of substitutions made
If doing the nested `gsub`, these two return values will be passed into the outer `gsub`, which accepts an optional fourth parameter specifying how many substitutions should be made. So the number of substitutions in the inner `gsub` determines the number of substitutions in the outer `gsub`: When the query doesn't contain a blank, that number of substitutions in the inner `gsub` is `0` and the outer `gsub` won't replace anything, leaving '${query}' in the `url`.
|
This PR fixes the issue in #284 for me. 👍 |
|
Thanks, and apologies for taking a while to get to this. |
eraserhd
pushed a commit
to eraserhd/Spoons
that referenced
this pull request
Jul 11, 2024
`string.gsub` returns two values: the string with substitutions and the number of substitutions made
If doing the nested `gsub`, these two return values will be passed into the outer `gsub`, which accepts an optional fourth parameter specifying how many substitutions should be made. So the number of substitutions in the inner `gsub` determines the number of substitutions in the outer `gsub`: When the query doesn't contain a blank, that number of substitutions in the inner `gsub` is `0` and the outer `gsub` won't replace anything, leaving '${query}' in the `url`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
When querying a single word (without spaces), the substitution string
${query}won't be replaced.Explanation/Fix
string.gsubreturns two values: the string with substitutions and the number of substitutions madeIf doing the nested
gsub, these two return values will be passed into the outergsub, which accepts an optional fourth parameter specifying how many substitutions should be made. So the number of substitutions in the innergsubdetermines the number of substitutions in the outergsub: When the query doesn't contain a blank, that number of substitutions in the innergsubis0and the outergsubwon't replace anything, leaving${query}in theurl.By first assigning the
gsubresult to a variable, the number of substitutions return value will be ignored.