Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only wrap fill in url css function when url is detected #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

json2d
Copy link

@json2d json2d commented Aug 19, 2019

this lets you use colors with the fill prop:

<Hexagon fill={"red"}/>
<Hexagon fill={"#f00"}/>
<Hexagon fill={"http://foo.bar/some-image.jpg"}/>

@jannikbuschke
Copy link
Collaborator

@json2d I think it is actually better to remove the "smartness" of the Hexagon and just expose the api of the underlying component.
Ill let this PR open to keep track of this issue, but have no intention to merge. Thanks for your effort, hope you will be ok with a slightly different solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants