-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚨 Make pyright happy #1840
🚨 Make pyright happy #1840
Conversation
Here's the translation to Chinese: 审阅指南 by Sourcery此拉取请求修改了多个 BaseModel 类,使用 更新的类图:Command、ConfigGroup、Task、PluginExtraData、BuildMatData、Goods、ReqResult、BotSetting 和 FileInfoclassDiagram
class Command {
- list~str~ params
- list~Example~ examples
}
class ConfigGroup {
- dict~str, ConfigModel~ configs
}
class Task {
- list check_args
}
class PluginExtraData {
- list~Command~ commands
- set~str~ aliases
}
class BuildMatData {
- list~int|float~ data
- list~str~ x_index
- list~int|float~ y_index
- list~str~ bar_color
}
class Goods {
- list~Callable~ before_handle
- list~Callable~ after_handle
- dict~str, str~ kwargs
}
class ReqResult {
- list~FriendRequestResult~ friend
- list~GroupRequestResult~ group
}
class BotSetting {
- dict~str, list~str~~ platform_superusers
- dict~str, str~ qbot_id_data
}
class FileInfo {
- list~FileInfo~ files
}
note for Command "更新为对 params 和 examples 使用 field(default_factory=list)"
note for ConfigGroup "更新为对 configs 使用 field(default_factory=dict)"
note for Task "更新为对 check_args 使用 field(default_factory=list)"
note for PluginExtraData "更新为对 commands 使用 field(default_factory=list),对 aliases 使用 field(default_factory=set)"
note for BuildMatData "更新为对 data、x_index、y_index 和 bar_color 使用 field(default_factory=list)"
note for Goods "更新为对 before_handle 和 after_handle 使用 field(default_factory=list),对 kwargs 使用 field(default_factory=dict)"
note for ReqResult "更新为对 friend 和 group 使用 field(default_factory=list)"
note for BotSetting "更新为对 platform_superusers 和 qbot_id_data 使用 field(default_factory=dict)"
note for FileInfo "更新为对 files 使用 field(default_factory=list)"
文件级别变更
提示和命令与 Sourcery 交互
自定义您的体验访问您的仪表板以:
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThis pull request modifies several BaseModel classes to use Updated class diagram for Command, ConfigGroup, Task, PluginExtraData, BuildMatData, Goods, ReqResult, BotSetting, and FileInfoclassDiagram
class Command {
- list~str~ params
- list~Example~ examples
}
class ConfigGroup {
- dict~str, ConfigModel~ configs
}
class Task {
- list check_args
}
class PluginExtraData {
- list~Command~ commands
- set~str~ aliases
}
class BuildMatData {
- list~int|float~ data
- list~str~ x_index
- list~int|float~ y_index
- list~str~ bar_color
}
class Goods {
- list~Callable~ before_handle
- list~Callable~ after_handle
- dict~str, str~ kwargs
}
class ReqResult {
- list~FriendRequestResult~ friend
- list~GroupRequestResult~ group
}
class BotSetting {
- dict~str, list~str~~ platform_superusers
- dict~str, str~ qbot_id_data
}
class FileInfo {
- list~FileInfo~ files
}
note for Command "Updated to use field(default_factory=list) for params and examples"
note for ConfigGroup "Updated to use field(default_factory=dict) for configs"
note for Task "Updated to use field(default_factory=list) for check_args"
note for PluginExtraData "Updated to use field(default_factory=list) for commands and field(default_factory=set) for aliases"
note for BuildMatData "Updated to use field(default_factory=list) for data, x_index, y_index, and bar_color"
note for Goods "Updated to use field(default_factory=list) for before_handle and after_handle, and field(default_factory=dict) for kwargs"
note for ReqResult "Updated to use field(default_factory=list) for friend and group"
note for BotSetting "Updated to use field(default_factory=dict) for platform_superusers and qbot_id_data"
note for FileInfo "Updated to use field(default_factory=list) for files"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嘿 @BalconyJH - 我已经审查了你的更改,看起来非常棒!
以下是我在审查期间查看的内容
- 🟢 一般性问题:一切看起来都很好
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟢 复杂性:一切看起来都很好
- 🟢 文档:一切看起来都很好
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将使用这些反馈来改进你的评论。
Original comment in English
Hey @BalconyJH - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
No description provided.