Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: use brew deps to detect if subversion is required #202784

Merged
merged 3 commits into from
Feb 2, 2025

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Dec 30, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Simplify the check if subversion is required in scheduled.yml workflow.

Follow-up of #201901 and Homebrew/brew#19000

@Moisan Moisan requested review from MikeMcQuaid and a team as code owners December 30, 2024 16:59
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files labels Dec 30, 2024
@Moisan Moisan force-pushed the workflows_scheduled_implicit branch from 95c583f to 4005a15 Compare January 17, 2025 19:10
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@carlocab carlocab force-pushed the workflows_scheduled_implicit branch from 4005a15 to 4ea47ac Compare February 2, 2025 16:30
@carlocab carlocab enabled auto-merge February 2, 2025 16:30
@carlocab carlocab added this pull request to the merge queue Feb 2, 2025
Merged via the queue into master with commit 7c08465 Feb 2, 2025
21 checks passed
@carlocab carlocab deleted the workflows_scheduled_implicit branch February 2, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants