mac-storage-manager 2.0.1: new formula #209312
Conversation
github-actions
bot
added
automerge-skip
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
| license "AGPL-3.0-only" | ||
| depends_on "jq" | ||
| depends_on "newt" | ||
| def install | ||
| folder = "mac-storage-manager-2.0.0" |
There was a problem hiding this comment.
| license "AGPL-3.0-only" | |
| depends_on "jq" | |
| depends_on "newt" | |
| def install | |
| folder = "mac-storage-manager-2.0.0" | |
| license "AGPL-3.0-only" | |
| depends_on "jq" | |
| depends_on "newt" | |
| def install | |
| folder = "mac-storage-manager-2.0.0" |
| depends_on "newt" | ||
| def install | ||
| folder = "mac-storage-manager-2.0.0" | ||
| folder = "." unless File.directory?(folder) |
| (bin/"mac-storage-manager").write <<~EOS | ||
| #!/bin/sh | ||
| export MAC_STORAGE_MANAGER_SHARE="#{pkgshare}" | ||
| exec #{libexec}/application_size_checker.sh "$@" | ||
| EOS | ||
| (bin/"mac-storage-manager").chmod 0755 |
There was a problem hiding this comment.
This should use write_env_script
| (bin/"mac-storage-manager").chmod 0755 | ||
| end | ||
| test do | ||
| output = shell_output("#{bin}/mac-storage-manager --help") |
There was a problem hiding this comment.
We need a test that exercises the some of the functionality of the app. Version checks or usage checks (foo --version or foo --help) are not sufficient, as explained in the formula cookbook.
In most cases, a good test would involve running a simple test case: run #{bin}/foo input.txt.
- Then you can check that the output is as expected (with assert_equal or assert_match on the output of shell_output)
- You can also check that an output file was created, if that is expected: assert_predicate testpath/"output.txt", :exist?
Some advice for specific cases:
- If the formula is a library, compile and run some simple code that links against it. It could be taken from upstream's documentation / source examples.
- If the formula is for a GUI program, try to find some function that runs as command-line only, like a format conversion, reading or displaying a config file, etc.
- If the software cannot function without credentials, a test could be to try to connect with invalid credentials (or without credentials) and confirm that it fails as expected.
- Same if the software requires a virtual machine, docker instance, etc. to be running.
| @@ -0,0 +1,28 @@ | |||
| class MacStorageManager < Formula | |||
| desc "Cross-platform tool to reclaim disk space by removing large applications" | |||
| homepage "https://github.com/NarekMosisian/mac-storage-manager" | |||
There was a problem hiding this comment.
We frown on authors submitting their own work unless it is very popular.
https://docs.brew.sh/Acceptable-Formulae#niche-or-self-submitted-stuff
|
Hi, this seems like a nice software, but not notable enough for us to package in Homebrew for now. This is not a decision on the merits of the software, but we cannot distribute every single piece of software and have to draw a line on “notability” somewhere. Of course, we would be happy to reconsider in the future. Please consider hosting it in a personal tap, which is very easy to do: https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap |
|
Hi @SMillerDev, First of all, my apologies for the delayed response—I only recently saw your comments. Thank you for taking the time to review my PR and provide detailed feedback. I understand and respect your points regarding: Formula Technicals
Project NotabilityI appreciate you clarifying the policy that mac-storage-manager isn’t currently notable enough for Homebrew/homebrew-core. I won’t dispute that decision. Instead, I’ll maintain the formula in a personal tap so users can still install it if they wish. If the project gains wider adoption in the future, I’d be happy to revisit a submission to homebrew-core at that time. Thank you again for your time and for maintaining Homebrew. Your feedback has been invaluable, and I’ll keep these best practices in mind for future contributions! |
This formula adds mac-storage-manager, a cross-platform shell script that helps reclaim disk space by identifying and safely removing large applications (including associated files).
Project Links:
Why it's useful:
Testing:
brew install --build-from-source mac-storage-managersucceeds locally.brew audit --strict mac-storage-managerpasses without issues.Thank you for reviewing this submission!