linenoise 1.0 (new formula) #40052
linenoise 1.0 (new formula) #40052
Conversation
| sha256 "f5054a4fe120d43d85427cf58af93e56b9bb80389d507a9bec9b75531a340014" | ||
|
|
||
| def install | ||
| system "make", "install" |
There was a problem hiding this comment.
The install location needs to be specified.
|
My original pull request was missing a required patch. Added. |
|
|
||
| def patches | ||
| # add dylib to the makefile | ||
| DATA |
There was a problem hiding this comment.
You can just make this patch :DATA without wrapping it in a def.
zostay
force-pushed
the
linenoise
branch
3 times, most recently
from
d4dde34 to
babe137
Compare
|
I believe I've now straightened out all the strict audit and testing issues unless someone can point out a new problem. |
|
One last thing and then it looks good. The patch needs a comment, and ideally a link to an upstream report about the issue, i.e. # Why I needed to change this
# Link to report upstream where I reported the need to patch this element
patch :DATA |
Basic formula for the released version of the linenoise readline lib.
|
Added a comment and submitted an issue upstream to link to as suggested. |
|
|
||
| # Added patch to build linenoise as a dynamic library | ||
| # Upstream Issue: https://github.com/antirez/linenoise/issues/94 | ||
| patch :DATA |
There was a problem hiding this comment.
Please file this as a pull-request rather than just an issue. Until then I think we shouldn't release this as a dynamic library until upstream supports it.
There was a problem hiding this comment.
This patch is OS X centric and the upstream library is not, so I don't feel that it's legit as an upstream pull-request. I don't have the expertise to build such a patch.
There was a problem hiding this comment.
Please remove it then, thanks.
|
Any update here? |
|
This seems to have gone dead. Closing consequently. If you pick up interest later please feel free to resubmit as a new PR with the comments above addressed, Thanks! Thank you for the submission! |
Basic formula for the released version of the linenoise readline lib.
This should supersede #23833 from 2013.