Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't discard defaults during load of user data #384

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

esnible
Copy link
Member

@esnible esnible commented Feb 10, 2025

Fixes validate_pdl_model_defaults(scope["pdl_model_default_parameters"]) problem with pdl -f ./prompt.json single_round_chat.pdl example.

@esnible esnible requested a review from vazirim February 10, 2025 14:31
Copy link
Member

@vazirim vazirim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esnible esnible merged commit 40c832e into IBM:main Feb 10, 2025
6 checks passed
@esnible esnible deleted the keep-defaults-during-load branch February 10, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants