Skip to content

Commit

Permalink
Don't require channel config attr with default value
Browse files Browse the repository at this point in the history
  • Loading branch information
yhabteab authored and julianbrost committed May 24, 2024
1 parent 904980c commit 28b60a8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
5 changes: 2 additions & 3 deletions cmd/channel/email/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,8 @@ func (ch *Email) GetInfo() *plugin.Info {
},
},
{
Name: "sender_mail",
Type: "string",
Required: true,
Name: "sender_mail",
Type: "string",
Label: map[string]string{
"en_US": "Sender Address",
"de_DE": "Absenderadresse",
Expand Down
6 changes: 2 additions & 4 deletions cmd/channel/webhook/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ func (ch *Webhook) GetInfo() *plugin.Info {
"en_US": "HTTP request method used for the web request.",
"de_DE": "HTTP-Methode für die Anfrage.",
},
Default: "POST",
Required: true,
Default: "POST",
},
{
Name: "url_template",
Expand Down Expand Up @@ -79,8 +78,7 @@ func (ch *Webhook) GetInfo() *plugin.Info {
"en_US": "Comma separated list of expected HTTP response status code, e.g., 200,201,202,208,418",
"de_DE": "Kommaseparierte Liste erwarteter Status-Code der HTTP-Antwort, z.B.: 200,201,202,208,418",
},
Default: "200",
Required: true,
Default: "200",
},
}

Expand Down

0 comments on commit 28b60a8

Please sign in to comment.