Skip to content

Commit

Permalink
bugfix
Browse files Browse the repository at this point in the history
  • Loading branch information
@devlaam
devlaam committed Oct 5, 2016
1 parent 9365200 commit f837284
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions lorank8v1/upgrade
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

VERSION=$1
HWTARGET=lorank8v1
DOGTAG=$(md5sum /etc/dogtag)
DTSHORT=${DOGTAG:0:5}

# Stop on the first sign of trouble
set -e
Expand All @@ -25,12 +23,6 @@ then
exit 1
fi

if [ ! -d Lorank/$TARGETDIR/$DTSHORT ]
then
echo "ERROR: BBB Release not known, no initialization possible"
exit 1
fi

# Upgrade the Lorank tree
pushd Lorank
git checkout master
Expand Down

4 comments on commit f837284

@francisdb
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These commit messages are the worst ever 😕

@devlaam
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your point being? The removed code should not be in the upgrade script, for it serves no purpose.

@francisdb
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My point being that bugfix is not helpful as a commit message
http://chris.beams.io/posts/git-commit/

@matthijskooijman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also appreciate some more elaborate commit messages, as they can help understand what was changed and whether an upgrade would fix a problem or not...

Please sign in to comment.