Add traceback info to logger messages within exceptions #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mjsir911 I have read and I can say that I approve this contribution to djangosaml2 that improve the debug information when some error might be critical for a production system I look forward for the resolution of the issues we have in the unit tests, you can see how the CI fails. |
mjsir911
force-pushed
the
msirabella/logging_tracebacks
branch
from
5268ea1
to
95414a4
Compare
|
@peppelinux fixed the tests |
|
ok, let's then do this release can you please set 1.9.1 here? https://github.com/IdentityPython/djangosaml2/blob/master/setup.py#L30 |
mjsir911
force-pushed
the
msirabella/logging_tracebacks
branch
from
95414a4
to
e8c97cc
Compare
|
done @peppelinux |
peppelinux
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We were running into an old issue #294 that got resolved back in 1.3.1 #297, but it took us a bit to track down because we were getting them through email and weren't seeing any traceback info.
This PR enables traceback info to any logging calls that are might include traceback info / are inside exceptions.
Additionally it might be possible to remove the
f"{e}"from these logging calls since it's now included in the traceback / exception info that shows up in the logs, but I haven't done that since y'all do that elsewhere too.