Skip to content

Commit

Permalink
Revised messages and documentation
Browse files Browse the repository at this point in the history
  • Loading branch information
@Ircama
Ircama committed Dec 31, 2024
1 parent 89ffe44 commit 2ea43f7
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 17 deletions.
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ For the following models there is no known way to read the EEPROM via SNMP proto

- [ET-2800](https://github.com/Ircama/epson_print_conf/issues/27)
- [ET-2850 ET-2851 ET-2853 ET-2855 ET-2856](https://github.com/Ircama/epson_print_conf/issues/26)
- [ET-4800](https://github.com/Ircama/epson_print_conf/issues/29) might not work, to be verified
- [ET-4800](https://github.com/Ircama/epson_print_conf/issues/29) with new firmware (older firmware might work)
- [L3250](https://github.com/Ircama/epson_print_conf/issues/35)
- [XP-7100 with firmware version YL25O7 (25 Jul 2024)](https://github.com/Ircama/epson_print_conf/issues/42) (firmware YL11K6 works)

Expand Down
2 changes: 1 addition & 1 deletion epson_print_conf.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2149,7 +2149,7 @@ def update_parameter(

def reset_waste_ink_levels(self, dry_run=False) -> bool:
"""
Set waste ink levels to 0.
Set waste ink levels to the values specified in the configuration.
"""
if not self.parm:
logging.error("EpsonPrinter - invalid API usage")
Expand Down
31 changes: 16 additions & 15 deletions ui.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ def show_help(self):
'import pprint;pprint.pprint(self.printer.status_parser(self.printer.snmp_mib("1.3.6.1.4.1.1248.1.2.2.1.1.1.4.1")[1]))\n'
"self.printer.read_eeprom_many([0])\n"
"self.printer.read_eeprom(0)\n"
"self.printer.reset_waste_ink_levels()\n"
"self.printer.snmp_mib(self.printer.eeprom_oid_read_address(0))\n"
"self.printer.snmp_mib('1.3.6.1.4.1.1248.1.2.2.44.1.1.2.1.124.124.7.0.25.7.65.190.160.0.0')\n"
"self.get_ti_date(cursor=True)"
Expand Down Expand Up @@ -368,7 +369,7 @@ def __init__(
# Create Help menu
help_menu = Menu(menubar, tearoff=0)
menubar.add_cascade(label="Help", menu=help_menu)
help_menu.add_command(label="Help", command=self.open_help_browser)
help_menu.add_command(label="Usage guide", command=self.open_help_browser)
help_menu.add_command(label="Program Information", command=self.show_program_info)

# Setup frames
Expand Down Expand Up @@ -1083,7 +1084,7 @@ def keep_printer_conf(self):
self.status_text.insert(tk.END, '[ERROR]', "error")
self.status_text.insert(
tk.END,
': Select a valid printer model.\n'
' Select a valid printer model.\n'
)
return
keep_model = self.model_var.get()
Expand All @@ -1105,7 +1106,7 @@ def remove_printer_conf(self):
self.status_text.insert(tk.END, '[ERROR]', "error")
self.status_text.insert(
tk.END,
': Select a valid printer model.\n'
' Select a valid printer model.\n'
)
return
remove_model = self.model_var.get()
Expand Down Expand Up @@ -1410,7 +1411,7 @@ def get_po_mins(self, cursor=True):
self.status_text.insert(tk.END, '[ERROR]', "error")
self.status_text.insert(
tk.END,
f": Missing 'Power off timer' in configuration\n",
f" Missing 'Power off timer' in configuration\n",
)
self.config(cursor="")
self.update_idletasks()
Expand Down Expand Up @@ -1457,7 +1458,7 @@ def get_ser_number(self, cursor=True):
self.status_text.insert(tk.END, '[ERROR]', "error")
self.status_text.insert(
tk.END,
f": Improper values in printer serial number.\n",
f" Improper values in printer serial number.\n",
)
self.config(cursor="")
self.update_idletasks()
Expand All @@ -1466,7 +1467,7 @@ def get_ser_number(self, cursor=True):
self.status_text.insert(tk.END, '[ERROR]', "error")
self.status_text.insert(
tk.END,
f": Cannot retrieve the printer serial number.\n",
f" Cannot retrieve the printer serial number.\n",
)
self.config(cursor="")
self.update_idletasks()
Expand Down Expand Up @@ -1508,7 +1509,7 @@ def get_mac_address(self, cursor=True):
self.status_text.insert(tk.END, '[ERROR]', "error")
self.status_text.insert(
tk.END,
f": Cannot retrieve the printer WiFi MAC address.\n",
f" Cannot retrieve the printer WiFi MAC address.\n",
)
self.config(cursor="")
self.update_idletasks()
Expand Down Expand Up @@ -1539,7 +1540,7 @@ def get_current_eeprom_values(self, values, label):
self.status_text.insert(
tk.END,
f' Cannot read EEPROM values for "{label}"'
f': invalid printer model selected: {self.printer.model}.\n'
f' invalid printer model selected: {self.printer.model}.\n'
)
self.config(cursor="")
self.update_idletasks()
Expand Down Expand Up @@ -1575,7 +1576,7 @@ def set_po_mins(self, cursor=True):
self.status_text.insert(tk.END, '[ERROR]', "error")
self.status_text.insert(
tk.END,
f": Missing 'Power off timer' in configuration\n",
f" Missing 'Power off timer' in configuration\n",
)
self.config(cursor="")
self.update_idletasks()
Expand Down Expand Up @@ -1830,7 +1831,7 @@ def get_ti_date(self, cursor=True):
self.status_text.insert(tk.END, '[ERROR]', "error")
self.status_text.insert(
tk.END,
f": Missing 'First TI received time' in configuration\n",
f" Missing 'First TI received time' in configuration\n",
)
self.config(cursor="")
self.update_idletasks()
Expand All @@ -1841,7 +1842,7 @@ def get_ti_date(self, cursor=True):
self.status_text.insert(tk.END, '[ERROR]', "error")
self.status_text.insert(
tk.END,
": No data from 'First TI received time'."
" No data from 'First TI received time'."
" Check printer configuration.\n",
)
self.config(cursor="")
Expand Down Expand Up @@ -1882,7 +1883,7 @@ def set_ti_date(self, cursor=True):
self.status_text.insert(tk.END, '[ERROR]', "error")
self.status_text.insert(
tk.END,
f": Missing 'First TI received time' in configuration\n",
f" Missing 'First TI received time' in configuration\n",
)
self.config(cursor="")
self.update_idletasks()
Expand Down Expand Up @@ -2030,14 +2031,14 @@ def reset_printer_model(self):
self.status_text.insert(tk.END, '[ERROR]', "error")
self.status_text.insert(
tk.END,
': Unknown printer model '
' Unknown printer model '
f'"{self.model_var.get()}"\n',
)
else:
self.status_text.insert(tk.END, '[ERROR]', "error")
self.status_text.insert(
tk.END,
': Select a valid printer model.\n'
' Select a valid printer model.\n'
)
self.config(cursor="")
self.update()
Expand Down Expand Up @@ -2230,7 +2231,7 @@ def get_values(addresses):
self.status_text.insert(
tk.END,
f' Cannot read EEPROM values for addresses "{addresses}"'
': invalid printer model selected.\n'
' invalid printer model selected.\n'
)
self.config(cursor="")
self.update_idletasks()
Expand Down

0 comments on commit 2ea43f7

Please sign in to comment.