Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx only one linked files showing in tooltip #12471

Closed
wants to merge 9 commits into from

Conversation

MhammedAhmmed
Copy link

Solve #12470

problem: Hover over the "Linked Files" tab in the entry editor.
Expected Behavior: The tooltip should display all linked files, not just the first one.

Solution: Modify createFileTooltip method to show all links seperated by "\n"

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

bandicam 2025-02-07 23-42-55-656 - frame at 0m4s

@Siedlerchr Siedlerchr changed the title Fix 12470 FIx only one linked files showing in tooltip Feb 8, 2025
return Localization.lang("Open file %0", linkedFiles.getFirst().getLink());
StringBuilder tooltipText = new StringBuilder();

// Iterate through all linked files and append their links to the tooltip text
Copy link
Member

@Siedlerchr Siedlerchr Feb 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all here comments as the code is self explanatory

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback! I've removed all the comments.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.

In case of issues with the import order, double check that you activated Auto Import.
You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports.

@Siedlerchr
Copy link
Member

please take a look at the failing test(s)

@MhammedAhmmed
Copy link
Author

Ok, I'm trying.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.

In case of issues with the import order, double check that you activated Auto Import.
You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports.

@subhramit
Copy link
Member

subhramit commented Feb 9, 2025

Hey @MhammedAhmmed, thank you for your interest and effort in contributing.
Unfortunately, someone is already assigned to this issue, so we will not be able to accept your PR unless they give it up or are inactive.

Please ask to be assigned or use the "assign-me" action whenever you pick your next issue!

@subhramit
Copy link
Member

Reopen in future if needed.

@subhramit subhramit closed this Feb 9, 2025
@MhammedAhmmed
Copy link
Author

Apologies for the confusion, and thanks for the update. I'll be sure to ask for assignment next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants