-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIx only one linked files showing in tooltip #12471
Conversation
return Localization.lang("Open file %0", linkedFiles.getFirst().getLink()); | ||
StringBuilder tooltipText = new StringBuilder(); | ||
|
||
// Iterate through all linked files and append their links to the tooltip text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all here comments as the code is self explanatory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feedback! I've removed all the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
In case of issues with the import order, double check that you activated Auto Import.
You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports.
please take a look at the failing test(s) |
Ok, I'm trying. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
In case of issues with the import order, double check that you activated Auto Import.
You can trigger fixing imports by pressing Ctrl+Alt+O to trigger Optimize Imports.
Hey @MhammedAhmmed, thank you for your interest and effort in contributing. Please ask to be assigned or use the "assign-me" action whenever you pick your next issue! |
Reopen in future if needed. |
Apologies for the confusion, and thanks for the update. I'll be sure to ask for assignment next time. |
Solve #12470
problem: Hover over the "Linked Files" tab in the entry editor.
Expected Behavior: The tooltip should display all linked files, not just the first one.
Solution: Modify createFileTooltip method to show all links seperated by "\n"
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)