Use range over int in benchmarks

Jacalz · Feb 24, 2025 · 4a4bd11 · 4a4bd11
1 parent 1d2eadd
commit 4a4bd11
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/completion/completion_test.go b/completion/completion_test.go
@@ -21,7 +21,7 @@ func generator(match string) []string {
 func TestTabCompleter_Next(t *testing.T) {
 	cmpl := &TabCompleter{Generate: generator}
 
-	for i := 0; i <= 9; i++ {
+	for i := range 10 {
 		num := string('0' + rune(i))
 		next := cmpl.Next(num)
 		assert.Equal(t, num, next)

diff --git a/internal/transport/completion_test.go b/internal/transport/completion_test.go
@@ -13,7 +13,7 @@ func BenchmarkNameplateCompletion(b *testing.B) {
 
 	local := []string{}
 
-	for i := 0; i < b.N; i++ {
+	for range b.N {
 		local = c.GenerateCodeCompletion("1-letterhead-be")
 	}
 

diff --git a/internal/transport/receiver.go b/internal/transport/receiver.go
@@ -136,8 +136,8 @@ func addFileIncrement(path string) (string, error) {
 	name = name[:len(name)-len(ext)]
 
 	// Add number at the end. Cap it to avoid doing checks forever.
-	for i := 1; i <= 5; i++ {
-		nr := strconv.Itoa(i)
+	for i := range 5 {
+		nr := strconv.Itoa(i + 1)
 		incremented := filepath.Join(base, name+"("+nr+")"+ext)
 
 		_, err := os.Stat(incremented)

diff --git a/internal/ui/tabs_test.go b/internal/ui/tabs_test.go
@@ -19,7 +19,7 @@ func BenchmarkCreate(b *testing.B) {
 	b.StartTimer()
 
 	b.ReportAllocs()
-	for i := 0; i < b.N; i++ {
+	for range b.N {
 		tabs = Create(a, w)
 	}
 

diff --git a/internal/util/reader_test.go b/internal/util/reader_test.go
@@ -18,7 +18,7 @@ func TestProgressReader(t *testing.T) {
 	}, size)
 
 	temp := [1]byte{}
-	for i := int64(0); i < size; i++ {
+	for i := range size {
 		_, err := teeReader.Read(temp[:])
 		if err != nil {
 			t.Fatal(err)

diff --git a/internal/util/util_test.go b/internal/util/util_test.go
@@ -14,7 +14,7 @@ var globalValidationError error
 func BenchmarkCodeValidator(b *testing.B) {
 	local := error(nil)
 
-	for i := 0; i < b.N; i++ {
+	for range b.N {
 		local = CodeValidator("125-upset-universe-mistake")
 	}