-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move annotations into runtime, decouple compiler from annotations. #362
Comments
Dagger also does this, but it predates auto/common. |
Thinking we want: public AnnotationMirror findAnnotation(ExecutableElement element, String annotationFqcn);
public Map<String, Object> annotationProperties(AnnotationMirror annotation); |
This has no public-facing impact, so I'm going to punt from v8 as it's complicated and I don't want to block release. |
When are you planning to release v8? |
No plans at this time. On Mon, Nov 9, 2015, 9:05 AM Said Tahsin Dane [email protected]
|
Is anything holding back the release of the current snapshot version of v8? |
Yes On Wed, Feb 3, 2016 at 11:11 AM Maarten Billemont [email protected]
|
Anything the community can do to remove roadblocks? |
What are the reasons? |
For various reasons, we need to kill the annotations artifact and move it into the runtime. The compiler will not be able to reference the annotation types directly.
This is annoying, but doable. Annotation information is available via
AnnotationMirror
instances from whichAnnotationValue
instances can be pulled. auto/common has some helpers here, and we'll have to write some of our own as well.Tests for the compiler will move into the runtime's tests which will allow them to reference Android types and runtime types without issue.
The text was updated successfully, but these errors were encountered: