Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move annotations into runtime, decouple compiler from annotations. #362

Open
JakeWharton opened this issue Sep 26, 2015 · 9 comments
Open
Milestone

Comments

@JakeWharton
Copy link
Owner

For various reasons, we need to kill the annotations artifact and move it into the runtime. The compiler will not be able to reference the annotation types directly.

This is annoying, but doable. Annotation information is available via AnnotationMirror instances from which AnnotationValue instances can be pulled. auto/common has some helpers here, and we'll have to write some of our own as well.

Tests for the compiler will move into the runtime's tests which will allow them to reference Android types and runtime types without issue.

@JakeWharton
Copy link
Owner Author

Dagger also does this, but it predates auto/common.

@JakeWharton
Copy link
Owner Author

Thinking we want:

public AnnotationMirror findAnnotation(ExecutableElement element, String annotationFqcn);
public Map<String, Object> annotationProperties(AnnotationMirror annotation);

@JakeWharton JakeWharton changed the title Move annotations into runtime, decouple compiler from runtime. Move annotations into runtime, decouple compiler from annotations. Sep 26, 2015
@JakeWharton
Copy link
Owner Author

This has no public-facing impact, so I'm going to punt from v8 as it's complicated and I don't want to block release.

@JakeWharton JakeWharton modified the milestones: 8.0.0, 9.0.0 Oct 10, 2015
@tasomaniac
Copy link

When are you planning to release v8?

@JakeWharton
Copy link
Owner Author

No plans at this time.

On Mon, Nov 9, 2015, 9:05 AM Said Tahsin Dane [email protected]
wrote:

When are you planning to release v8?


Reply to this email directly or view it on GitHub
#362 (comment)
.

@lhunath
Copy link

lhunath commented Feb 3, 2016

Is anything holding back the release of the current snapshot version of v8?

@JakeWharton
Copy link
Owner Author

Yes

On Wed, Feb 3, 2016 at 11:11 AM Maarten Billemont [email protected]
wrote:

Is anything holding back the release of the current snapshot version of v8?


Reply to this email directly or view it on GitHub
#362 (comment)
.

@lhunath
Copy link

lhunath commented Feb 3, 2016

Anything the community can do to remove roadblocks?

@fengdai
Copy link

fengdai commented Mar 30, 2016

For various reasons

What are the reasons?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants