Support binding array resources (String, int, text and TypedArray). #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #300 |
| String methodName = getArrayResourceMethodName(element); | ||
| if (methodName == null) { | ||
| error(element, | ||
| "@%s field type must be one of: " + "'String[], int[], CharSequence[], %s'. (%s.%s)", |
There was a problem hiding this comment.
needless + between string contstants
|
Looks great. A couple small nits. |
|
👍 thanks! |
JakeWharton
added a commit
that referenced
this pull request
Jul 7, 2015
Support binding array resources (String, int, text and TypedArray).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces
@BindStringArraywith@BindArrayin order to support multiple array types. The type of annotated element will dictate which method of theResourcesclass to invoke in order to fetch the array.