compose gradle plugin, lazy initialization of teamId for iOS deploy (#…

…2132)
JetBrains · Jun 20, 2022 · 85a7e6c · 85a7e6c
1 parent 8faecbb
commit 85a7e6c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/.../org/jetbrains/compose/experimental/uikit/internal/configureTaskToGenerateXcodeProject.kt b/.../org/jetbrains/compose/experimental/uikit/internal/configureTaskToGenerateXcodeProject.kt
@@ -13,7 +13,7 @@ internal fun Project.configureTaskToGenerateXcodeProject(
     id: String,
     projectName: String,
     bundleIdPrefix: String,
-    teamId: String? = null,
+    getTeamId: () -> String? = { null },
     taskInstallXcodeGen: TaskProvider<*>,
 ): TaskProvider<AbstractComposeIosTask> = tasks.composeIosTask<AbstractComposeIosTask>("iosGenerateXcodeProject$id") {
     dependsOn(taskInstallXcodeGen)
@@ -26,7 +26,7 @@ internal fun Project.configureTaskToGenerateXcodeProject(
             options:
               bundleIdPrefix: $bundleIdPrefix
             settings:
-              ${if (teamId != null) "DEVELOPMENT_TEAM: \"$teamId\"" else ""}
+              ${if (getTeamId() != null) "DEVELOPMENT_TEAM: \"${getTeamId()}\"" else ""}
               CODE_SIGN_IDENTITY: "iPhone Developer"
               CODE_SIGN_STYLE: Automatic
               MARKETING_VERSION: "1.0"

diff --git a/.../kotlin/org/jetbrains/compose/experimental/uikit/internal/registerConnectedDeviceTasks.kt b/.../kotlin/org/jetbrains/compose/experimental/uikit/internal/registerConnectedDeviceTasks.kt
@@ -28,15 +28,17 @@ fun Project.registerConnectedDeviceTasks(
         id = id,
         projectName = projectName,
         bundleIdPrefix = bundleIdPrefix,
-        teamId = deploy.teamId ?: getLocalProperty(TEAM_ID_PROPERTY_KEY)
-        ?: error(
-            buildString {
-                appendLine("In local.properties (${localPropertiesFile.absolutePath})")
-                appendLine("Add property")
-                appendLine("$TEAM_ID_PROPERTY_KEY=***")
-                appendLine("Or set teamId in deploy with id: $id")
-            }
-        ),
+        getTeamId = {
+            deploy.teamId ?: getLocalProperty(TEAM_ID_PROPERTY_KEY)
+            ?: error(
+                buildString {
+                    appendLine("In local.properties (${localPropertiesFile.absolutePath})")
+                    appendLine("Add property")
+                    appendLine("$TEAM_ID_PROPERTY_KEY=***")
+                    appendLine("Or set teamId in deploy with id: $id")
+                }
+            )
+        },
         taskInstallXcodeGen = taskInstallXcodeGen,
     )