Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JEWEL-734] Menu appearance does not match the Swing one #2933

Closed
wants to merge 1 commit into from
Closed

[JEWEL-734] Menu appearance does not match the Swing one #2933

wants to merge 1 commit into from

Conversation

hamen
Copy link
Collaborator

@hamen hamen commented Jan 28, 2025 •
edited
Loading

Please review and merge after #2921

JEWEL
image image

SWING
image
image

IDE
image

Reference JetBrains/jewel#734

@hamen hamen self-assigned this Jan 28, 2025
@rock3r rock3r self-requested a review January 28, 2025 14:57
@rock3r
Copy link
Collaborator

rock3r commented Jan 28, 2025

This PR only seems to address standalone; can you please confirm they already look correct in bridge?

@hamen
Copy link
Collaborator Author

hamen commented Jan 28, 2025

This PR only seems to address standalone; can you please confirm they already look correct in bridge?

I also added the bits for the Bridge now.

@hamen hamen marked this pull request as ready for review January 28, 2025 15:41
@hamen hamen mentioned this pull request Jan 28, 2025
Open
@jakub-senohrabek
Copy link
Collaborator

Please rebase this after #2921 is merged

@hamen
Copy link
Collaborator Author

hamen commented Jan 31, 2025 •
edited
Loading

I went for merge because rebase was driving me crazy. These PRs are too many commits behind, and rebasing forces me to fix the same conflict over and over and over. It's not sustainable. Merge works fine, and considering that we are squashing when we go into master, it should be invisible anyway.

@rock3r
Copy link
Collaborator

rock3r commented Jan 31, 2025

Having a thousand commits per PR surely doesn't help with rebasing :) It should be fine. Hopefully Kuba manages to get the other pending PRs merged so this becomes less of an issue

@rock3r
[JEWEL-734] Menu appearance does not match the Swing one
8d500c2 
This realigns the menu appearance with the Swing ones, as it had drifted
apart since being implemented.
@rock3r
Copy link
Collaborator

rock3r commented Feb 13, 2025

I squashed the relevant changes for this PR into a single commit, off the top of master, and removed all unrelated changes.

@rock3r rock3r deleted the im-jewel-734 branch February 14, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rock3r rock3r rock3r approved these changes

Assignees

@hamen hamen

Labels
jewel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamen @rock3r @jakub-senohrabek