Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required modules of a plugin to the classpath automatically when 'bundledPlugins' is used (#1883) #1884

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

chashnikov
Copy link
Member

@chashnikov chashnikov commented Feb 12, 2025

A content module registered as 'required' or 'embedded' in the plugin descriptor is guaranteed to be loaded if the plugin itself is loaded. Since 'depends' tag adds classloaders from all content modules as parent classloaders, references to classes from such modules will be resolved at runtime.

Related Issue

#1883

Motivation and Context

To fix #1883.

How Has This Been Tested

I tested it manually with dependency on YAML plugin in 251.20015.29-EAP-SNAPSHOT build. Not sure how to create a proper automatic test.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have included my change in the CHANGELOG.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

chashnikov and others added 2 commits February 12, 2025 16:44
…'bundledPlugins' is used (#1883)

A content module registered as 'required' or 'embedded' in the plugin descriptor is guaranteed to be loaded if the plugin itself is loaded. Since 'depends' tag adds classloaders from all content modules as parent classloaders, references to classes from such modules will be resolved at runtime.
@hsz hsz merged commit f6a455d into main Feb 13, 2025
2 checks passed
@hsz hsz deleted the nikolay.chashnikov/add-required-modules-automatically branch February 13, 2025 04:10
@hsz
Copy link
Member

hsz commented Feb 13, 2025

Thank you!

@hsz hsz added this to the next milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required modules of a plugin aren't automatically added to dependencies by 'bundledPlugins'
2 participants