Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart plugin config fix #921

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Dart plugin config fix #921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c1318e
Fix README.md
Lootwig Sep 14, 2024
d97beeb
fix module dependency declarations
Lootwig Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Dart/Dart-community.iml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,6 @@
</library>
</orderEntry>
</component>
</module>
<orderEntry type="module" module-name="intellij.javascript.debugger" />
<orderEntry type="module" module-name="intellij.platform.testFramework" scope="TEST" />
</module>
14 changes: 8 additions & 6 deletions Dart/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,30 +42,32 @@ Prerequisites:
(`intellij` > `idea` > `community` > `main`), click `[+]` and add a module
dependency on the `Dart-community` module.

4. Open Settings (Preferences) | Version Control | Directory Mappings and add `intellij-plugins` as a 3rd Git root if it's not already there.
4. Install the "JavaScriptDebugger" plugin, then [add its JAR file to the project SDK's classpath](https://plugins.jetbrains.com/docs/intellij/plugin-dependencies.html#plugin-devkit)

5. The project is ready to use. Use `IDEA` run configuration to start IntelliJ IDEA Community Edition + Dart Plugin from sources.
5. Open Settings (Preferences) | Version Control | Directory Mappings and add `intellij-plugins` as a 3rd Git root if it's not already there.

6. In order to be able to run tests that use real Dart Analysis Server, do the following:
6. The project is ready to use. Use `IDEA` run configuration to start IntelliJ IDEA Community Edition + Dart Plugin from sources.

7. In order to be able to run tests that use real Dart Analysis Server, do the following:
- Make sure you have Dart SDK installed locally. It can be downloaded from the [Dart SDK Archive](https://dart.dev/tools/sdk/archive).
- Open `Run | Edit Configurations...` dialog.
- Click `Edit configuration templates...` in the bottom-left corner.
- Find `JUnit` and add Dart SDK path to the VM Options field like this: `-Ddart.sdk=path/to/real/dart/sdk`.
VM Options field is the one that has only `-ea` text by default.

7. To run all Dart plugin tests, right-click the `Dart/testSrc` folder in the Project View and select 'Run all tests'.
8. To run all Dart plugin tests, right-click the `Dart/testSrc` folder in the Project View and select 'Run all tests'.
- To run only those tests that do not use real Dart Analysis Server, use context menu of the `Dart/testSrc/com/jetbrains/lang/dart` folder.
(At the moment of writing, 3 of them are expected to fail: `DartInjectionTest.testRegExp()`, `DartHighlightingTest.testSimplePolymer()`,
and `DartHighlightingTest.testScriptSrcPathToPackagesFolder()`.)
- Tests that use real Dart Analysis Server reside in the `Dart/testSrc/com.jetbrains.dart/analysisServer` folder.
A few of them are expected to fail.

8. [Optional] To enable internal developer actions add "idea.is.internal=true"
9. [Optional] To enable internal developer actions add "idea.is.internal=true"
to the idea.properties file (Help -> Edit Custom Properties...). The menu actions Tools ->
View PSI Structure... as well as the Tools -> Internal Actions should be
visible after restarting.

9. Enjoy! All functionality should work. Most of the tests should pass.
10. Enjoy! All functionality should work. Most of the tests should pass.
Zero mandatory local changes in `intellij-plugins` repository.
There should be 3 locally changed files in `intellij-community` repository, each having exactly one added line,
just keep these files in a separate '~never commit' changelist and do not worry about them:
Expand Down