Initial commit for issue WEB-7671 Allow Handlebars/Mustache expression delimiters to be changed from the defaults #935
Conversation
|
Hi! Thanks for the contribution! It looks like the part to enable parsing with the new delimiters is not yet done. Are you planning to working on this? |
Hello Piotr yes I will try to finish the lexer and parser part, my main obstacle is I have been struggling to test the changes I make. Every time I build the plugin doesn't get installed in the sandbox IDE and when i try to install manually I get Either way I will try to finish this as I have another internal plugin I developed for my company that would really benefit from these changes which bundles this Handlebars/Mustache under the hood. |
|
Hi Piotr I’m having trouble with running the tests or runIde command making
it difficult to finish setup
…On Tue, Jan 21, 2025 at 6:17 AM Piotr Tomiak ***@***.***> wrote:
Hi! Thanks for the contribution! It looks like the part to enable parsing
with the new delimiters is not yet done. Are you planning to working on
this?
—
Reply to this email directly, view it on GitHub
<#935 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKGOP4HFV6UJLJYJEAWGT2D2LYUDXAVCNFSM6AAAAABVN6XRTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBUGQZTQNRQHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@SammoMichael - I am looking into the problem. It looks like the Gradle setup has degraded to the level it requires a lot of work. I'll let you know once I fix it, but it's gonna be on Monday at earliest. |
|
@SammoMichael - I've finally managed to fix the setup, sorry that it took so long. To be able to develop the change, you should switch to |
|
Awesome, thank you so much Piotr!
…On Tue, Jan 28, 2025 at 2:29 PM Piotr Tomiak ***@***.***> wrote:
@SammoMichael <https://github.com/SammoMichael> - I've finally managed to
fix the setup, sorry that it took so long. To be able to develop the
change, you should switch to 243 branch and develop the fix for that
branch. On master branch, the code is sometimes behind the released
platform, and you might not be able to compile it. Once the fix is ready, I
will apply it to the master branch.
—
Reply to this email directly, view it on GitHub
<#935 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKGOP4GX3NJKD3RCUQ6DO532M7LCDAVCNFSM6AAAAABVN6XRTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJZHA4DINRTHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Trying to finish this enhancement as it it would help very many companies and teams i (including mine)
As it is normal practice to use a custom delimiter for "first pass" hydration and reserve "{{ }}" mustache templates for second pass. Also people have requested "{% %}". This PR will allow one or more custom delimiters to be used and no longer considered error in the file they are embedded in