-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proxy colonies M1] Feat: Re-enable deployed proxy colony #4032
Conversation
81ae988
to
6295a4f
Compare
6916a6b
to
1d640db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export type EnableProxyColonyPayload = | ||
Action<ActionTypes.PROXY_COLONY_ENABLE>['payload']; | ||
|
||
// @TODO if metatx are enabled sent a metaTx instead of tx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually this isn't applicable here since we use the "old" way of sending out transactions :D
6295a4f
to
7e6f635
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Barring the feature flag (for which I already raised problems with in #4006) everything works
This is a tremendous amount or work which functions flawlessly! Nicely done! 💯
Feat: Re-enable deployed proxy colony
Chore: Update block ingestor hash
1d640db
to
f8ad014
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
un-deploy
it, so we're going to make use of theisActive
property for a proxy colony to know in which state it is. Nothing changes from the UI-wise, meaning you'll still need to create aManage supported chains
action and select theAdd
operation. However, behind the scenes, a different saga -enableProxyColony
- will be called.Block ingestor PR
Testing
TODO: So now for the testing, let's make sure we can
Add
andRemove
support for a chain as many times we want 🪄Step 1. Make sure your start a fresh dev env and run the
create-data
scriptStep 2. Go to http://localhost:9091/planex
Step 3. Create a
Manage supported chains
actionStep 4. Select the
Add chain support
operation andEthereum
as the chain and fill the other fieldsStep 5. Once the action is completed, you can run the following query
and should see the
isActive
flag is set totrue
Step 6. Create another
Manage supported chains
action.This time select the
Remove chain support
operation.You should see
Ethereum
as the only chain in the dropdown menu. Select it and fill the other fields.Step 7. You can run the query again and the
isActive
flag should be set tofalse
Step 8. And now let's actually test the re-enabling. So let's create another
Manage supported chains
action.Select
Add chain support
operation and for the chains you should seeEthereum
again in the chains list.Select it, fill the remaining fields and create the action.
Step 9. In the browser console you should see a log similar to this
Step 10. You can run the query again and the
isActive
flag should be set again totrue
Step 11. If you want to double check everything worked as expected, you can try creating again a
Manage supported chains
action. Select theRemove chain support
operation andEthereum
should be again in the chain dropdown list.Congrats! 🎉 Your mission of testing this PR has come to an end, but if you have other ideas, please do not hesitate to try them out 🥷
Diffs
New stuff ✨
enableProxyColony
sagauseDeployedChainIds
hookContributes to #3457