Feat/16220651 navigation streaming payments #4037
Open
+20
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
adam-strzelec
changed the base branch from
master
to
feat/streaming-payments-ui
adam-strzelec
force-pushed
the
feat/16220651-navigation-streaming-payments
branch
from
e844e58 to
1b48d09
Compare
iamsamgibbs
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Thanks for your work so far on this issue, it is looking good!
It seems like a couple of points have been missed from the original issue though. The URL should be changed to just /streaming
And the "Streaming" menu option should only appear when either the extension is installed, or if there have been streaming payments in the past (even once the extension is uninstalled).
Comment on lines
53
to
55
| // @TODO: uncomment when streaming payment is ready | ||
| // { | ||
| // title: formatText({ id: 'actions.streamingPayment' }), |
There was a problem hiding this comment.
Can remove this comment now :)
arrenv
requested changes
Jan 10, 2025
There was a problem hiding this comment.
@adam-strzelec Thank you for the PR, we still need to handle the rules based on the state of the extension.
Streaming payment page visibility
- Should be visible if the Streaming payment extension is installed or there has been any streams at all in the colony, even if the extension is no longer installed.
- In the case where there has been streams and the page is visible, but the extension is not installed, we need to show a banner that the extension is disabled and hide the “Create stream” button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add streaming payments to navigation and to action items
Testing
Navigation:
Financesin navigation barStreamingAction item:
Make paymentin navigation barStreaming paymentactionDiffs
New stuff ✨
Resolves - #4020