Fix: Funds card hover state #4043
Merged
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumzledz
approved these changes
Jan 7, 2025
bassgeta
approved these changes
Jan 9, 2025
mmioana
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Nice work on this one @iamsamgibbs 🙌
Cards are no longer clickable while loading and the hover state matches Figma 😎
Screen.Recording.2025-01-13.at.09.45.45.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where the funds cards were clickable before the card content had loaded in. It also fixes the hover styling.
Testing
Reload and hover over the funds whilst they are loading, make sure they are not clickable.
Once the are fully loaded, check the hover styling matches figma.
Figma: https://www.figma.com/design/gac6xVgGNCAge5Bia933dp/Dashboard?node-id=4878-84953&t=OpWCmWBoyrScYokI-4
Diffs
New stuff ✨
isLoadingprop to WidgetCardsItem component and disabled button wrapper whilst loadingChanges 🏗
Resolves #3654