-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Expandable rows not opening transaction #4048
Conversation
Fix: Expandable rows not opening transaction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this, I am now able to open the action!
Screen.Recording.2025-01-08.at.11.52.15.mov
I just wanted to clarify something on the original issue:
When a row is selected on mobile when an individual table row is expanded, the action should open
I'm not sure if this means when a row is collapsed, that tapping on the row should expand it, then when it is expanded, tapping again should open the action.
With the current implementation, when a row is collapsed, tapping on the row opens the action, you have to tap specifically on the arrow to expand / collapse the row.
I think the current implementation works well, I just wanted to clarify what is expected from the original issue.
I also noticed tapping in the "details" section of the row does nothing, you have to specifically tap on the main part of the row itself to open the action. Again, not sure if this is an issue or not.
@iamsamgibbs thanks for your review! I'm putting this back in |
Fix: Update colony action row clickable area
Hey @iamsamgibbs I have clarified with @melyndav and on mobile, the area which should trigger the opening of the action sidebar should be as following Only clicking on the expand icon should toggle the extra content. And on Would appreciate if you could check again 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks for clarifying this and getting it all fixed up, it's working very nicely now!
Screen.Recording.2025-01-13.at.14.13.09.mov
Desktop is unaffected:
Screen.Recording.2025-01-13.at.14.13.37.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good on my end @mmioana ! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested both the activity feed on the dashboard, as well as the one in the activity feed page. Both work as expected. Nicely done! 🥇
Description
Before
Screen.Recording.2025-01-07.at.19.26.23.mov
After
Screen.Recording.2025-01-07.at.19.25.15.mov
Testing
Please use a mobile simulator or just switch your browser to a width of
< 1024px
.Step 1. Go to
planex
and scroll to theRecent activity
tableStep 2. Click on any action and check that it opens the action sidebar
Step 3. Try expanding the action and check it still works as expected
Step 4. Check the column spacing is as expected
Step 5. Go to http://localhost:9091/planex/activity
Step 6. Repeat steps
2-4
and confirm everything still works as expectedDiffs
Changes 🏗
renderRowLink
for the activity tables regardless of screen sizeResolves #3877