[Split payment]: Fix validation errors #4050
Open
+48
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmioana
changed the title
mmioana
changed the base branch from
master
to
fix/4046-table-refactoring-findings
mmioana
force-pushed
the
fix/4046-table-refactoring-findings
branch
from
0a07e8e to
c736b32
Compare
Fix: Validation issues for split payment action
Fix: Remove transform from payments field in schema validation
mmioana
force-pushed
the
fix/3792-split-payment-disable-submit
branch
from
5460e86 to
2f5570d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove rowoption from theSplit payment's payments table if there is a single item. Also, I took the chance to fix some error messages for this action.Testing
TODO: Check the
Remove rowoption is not available if the payments table has a single item.Screen.Recording.2025-01-13.at.11.33.20.mov
Step 1. Create a
Split paymentactionStep 2. Click on the meatball menu on the payment's table.
Step 3.
Remove rowshould not be shownStep 4. Duplicate or add a new row. Now the
Remove rowshould be shown on any of the items.Step 5. Try to submit the form. Check the error messages are formatted
Step 6. Fill all the missing details and submit the form. This should happen without issues ✨
Diffs
Changes 🏗
Remove rowmeatball menu option is shown only if therecipients.length > 1Resolves #3792