Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Prevent stale claimable state #4056

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

rumzledz
Copy link
Contributor

@rumzledz rumzledz commented Jan 8, 2025

Description

After much investigation, I found that the effects I removed were redundant and were causing issues with how we control the claimed state. I have not been able to find an issue after removing them, hopefully this didn't break a flow that I'm not fully aware of 🤞

claim-fix

Testing

  1. Enable the Reputation extension
  2. Create a Mint Tokens motion
  3. Oppose and fully stake it
  4. Support and fully stake it
  5. On the Voting phase, approve it
  6. Finalise it
  7. Claim back the tokens
  8. Verify that
  • the Claim button doesn't linger
  • the Pending button doesn't linger

Resolves #3859

@rumzledz rumzledz self-assigned this Jan 8, 2025
@rumzledz rumzledz force-pushed the fix/3859-prevent-flakey-claim-pending-state branch 3 times, most recently from 5f825f7 to 20c9aa1 Compare January 8, 2025 17:52
@rumzledz rumzledz force-pushed the fix/3859-prevent-flakey-claim-pending-state branch from 20c9aa1 to 8f91c41 Compare January 8, 2025 18:15
@rumzledz rumzledz marked this pull request as ready for review January 9, 2025 11:09
@rumzledz rumzledz requested a review from a team as a code owner January 9, 2025 11:09
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither the claim button or the pending button linger.

(The reveal button was late to show up, but that is not related to this PR)

Screencast.from.2025-01-09.20-42-07.mp4

Copy link
Contributor

@davecreaser davecreaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. I don't see any regressions from removing the effects. Also just double checked in the user hub stakes and it is successfully updated to claimed there.

Also didn't see any lingering buttons so I'd say this is all good!

Screen.Recording.2025-01-17.at.20.07.30.mov
Screenshot 2025-01-17 at 20 09 39

Copy link
Contributor

@Nortsova Nortsova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You smashed it! 👏 Amazing work! Thank you for tackling such deep and annoying bugs. 😄

Now it doesn't get stuck at "pending" after claiming. 🎉

claimable-state

@rumzledz rumzledz merged commit 8dbbfab into master Jan 21, 2025
2 checks passed
@rumzledz rumzledz deleted the fix/3859-prevent-flakey-claim-pending-state branch January 21, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Payments]Pending button stuck after claiming motion on the Finalize step/ or Claim button appears twice
4 participants