Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Allow addition of proxy colonies with multisig #4061

Merged

Conversation

davecreaser
Copy link
Contributor

@davecreaser davecreaser commented Jan 9, 2025

Description

  • This PR adds functionality to create a proxy colony via voting reputation.

Block ingestor changes here

Testing

  • On a fresh dev env, install the multisig extension, and give multisig owner permissions to Leela
Screenshot 2025-01-09 at 16 34 16 Screenshot 2025-01-09 at 16 34 55
  • Run the following query to ensure that no proxy colonies currently exist
query MyQuery {
  listProxyColonies {
    items {
      chainId
      colonyAddress
      createdAt
      id
      isActive
      updatedAt
    }
  }
}
Screenshot 2025-01-09 at 16 27 45
  • Create a Manage supported chains action and choose multisig as the decision method
Screenshot 2025-01-09 at 16 36 10
  • Finalize the multisig motion
  • Run the query again to ensure that a proxy colony was made
query MyQuery {
  listProxyColonies {
    items {
      chainId
      colonyAddress
      createdAt
      id
      isActive
      updatedAt
    }
  }
}
Screenshot 2025-01-09 at 16 36 48

Diffs

New stuff

  • New block ingestor hash

Changes 🏗

  • Allow add proxy colony actions to be made with multisig

Resolves #3451

@davecreaser davecreaser marked this pull request as ready for review January 9, 2025 16:37
@davecreaser davecreaser requested a review from a team as a code owner January 9, 2025 16:37
@davecreaser davecreaser self-assigned this Jan 10, 2025
@bassgeta bassgeta force-pushed the feat/3450-add-proxy-colony-motion branch from 9cb2831 to 7bf5682 Compare January 14, 2025 10:58
@davecreaser davecreaser force-pushed the feat/3451-add-proxy-colony-multisig branch from cc2bce9 to 979e95e Compare January 14, 2025 17:45
@bassgeta bassgeta force-pushed the feat/3450-add-proxy-colony-motion branch from 7bf5682 to 2be129c Compare January 15, 2025 11:05
Base automatically changed from feat/3450-add-proxy-colony-motion to feat/M1-proxy-colonies January 15, 2025 12:15
@davecreaser davecreaser force-pushed the feat/3451-add-proxy-colony-multisig branch from e4032df to d38bdf2 Compare January 15, 2025 13:17
Copy link
Contributor

@rumzledz rumzledz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on this one @davecreaser! Can confirm I was able to deploy a Proxy Colony via Multi-Sig! 💯

Fresh dev env

Screenshot 2025-01-15 at 22 40 04

After deploying the Proxy Colony via Multi-Sig

Screenshot 2025-01-15 at 22 43 09 Screenshot 2025-01-15 at 22 43 15

Copy link
Contributor

@bassgeta bassgeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution, just works 💯
And really dope that you were able to fix my typo for motion finalization, sorry about that :')
Did a sanity check that the action is blocked for users without adequate permissions ✔️
image
Multi-sig shows up as an option ✔️
image
image

I am able to remove votes and vote as other users (after giving them MS permissions) ✔️
image
And finalization works, with the proxy being deployed 🎉
image
Additionally, the multisig motion is also tracking finalization data 😎
image

Copy link
Contributor

@mmioana mmioana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing @davecreaser with this PR we can now deploy proxy colonies using Multi-sig 🎉

Installed the Multi-sig extension
Screenshot 2025-01-16 at 14 24 28

Gave leela multi-sig permissions
Screenshot 2025-01-16 at 14 24 58

No proxy colonies are deployed at this point
Screenshot 2025-01-16 at 14 25 18

Created a Manage supported chains motion via Multi-sig
Screenshot 2025-01-16 at 14 25 59

Finalised it
Screenshot 2025-01-16 at 14 26 05

And 🎆 pam 🎆 the proxy colony is deployed!
Screenshot 2025-01-16 at 14 26 14

Now Ethereum is available only for the Remove operation
Screenshot 2025-01-16 at 14 30 40

And nowhere to be found for adding support 🦾
Screenshot 2025-01-16 at 14 30 43

Nice job!

@davecreaser davecreaser merged commit 8d53afb into feat/M1-proxy-colonies Jan 16, 2025
1 check passed
@davecreaser davecreaser deleted the feat/3451-add-proxy-colony-multisig branch January 16, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants