-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Allow addition of proxy colonies with multisig #4061
Feat: Allow addition of proxy colonies with multisig #4061
Conversation
9cb2831
to
7bf5682
Compare
cc2bce9
to
979e95e
Compare
7bf5682
to
2be129c
Compare
e4032df
to
d38bdf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work on this one @davecreaser! Can confirm I was able to deploy a Proxy Colony via Multi-Sig! 💯
Fresh dev env
After deploying the Proxy Colony via Multi-Sig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice solution, just works 💯
And really dope that you were able to fix my typo for motion finalization, sorry about that :')
Did a sanity check that the action is blocked for users without adequate permissions ✔️
Multi-sig shows up as an option ✔️
I am able to remove votes and vote as other users (after giving them MS permissions) ✔️
And finalization works, with the proxy being deployed 🎉
Additionally, the multisig motion is also tracking finalization data 😎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing @davecreaser with this PR we can now deploy proxy colonies using Multi-sig
🎉
Installed the Multi-sig
extension
Gave leela
multi-sig permissions
No proxy colonies are deployed at this point
Created a Manage supported chains
motion via Multi-sig
And 🎆 pam 🎆 the proxy colony is deployed!
Now Ethereum
is available only for the Remove
operation
And nowhere to be found for adding support 🦾
Nice job!
Description
Block ingestor changes here
Testing
Manage supported chains
action and choose multisig as the decision methodDiffs
New stuff ✨
Changes 🏗
Resolves #3451