fix: display streaming payment metadata for action and activity feed #4064
+17
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamsamgibbs
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Nice! This all looks good to me.
Unrelated to this issue, but I did notice I am able to create a streaming payment with a locked token from another colony. I'm guessing there should be an error validation for this (like there is for simple payments) as the payment fails when you go to claim it.
mmioana
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Nice work on this one @adam-strzelec 🥇
I created a few streaming payments
For this one there is an issue with the status pill as it shows the Limit reached even though it has not started yet, but I guess this can be handled in a separate PR 👍
And were shown correctly in the Activity feed 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Display streaming payment metadata for action and activity feed
Testing
Diffs
New stuff ✨
Resolves #4044