Fix setphase!(::FIRArbitrary, ϕ) similarly

Here, the problem is less severe as it requires an explcit call to `setphase!`
with a problematic phase which cannot be hit within normal `resample`
operation.

src/Filters/stream_filt.jl

@@ -227,6 +227,10 @@ end
 function setphase!(kernel::FIRArbitrary, ϕ::Real)
     ϕ >= zero(ϕ) || throw(ArgumentError("ϕ must be >= 0"))
     (ϕ, xThrowaway) = modf(ϕ)
+    if round(ϕ*kernel.Nϕ) == kernel.Nϕ
+        xThrowaway += 1
+        ϕ -= 1
+    end
     kernel.inputDeficit += round(Int, xThrowaway)
     kernel.ϕAccumulator = ϕ*(kernel.Nϕ) + 1.0
     kernel.ϕIdx         = round(kernel.ϕAccumulator)

test/filt_stream.jl

@@ -365,3 +365,7 @@ end
 # check that these don't throw; the output should actually probably be longer
 @test resample(1:2, 3, [zeros(2); 1; zeros(3)]) == [1, 0, 0, 2] # [1, 0, 0, 2, 0, 0]
 @test resample(1:2, 3//2, [zeros(2); 1; zeros(3)]) == [1, 0] # [1, 0, 0]
+let H = FIRFilter(2.22)
+    setphase!(H, 0.99)
+    @test length(filt(H, 1:2)) == 3
+end