Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codecov token secret to CI.yml #525

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

wheeheee
Copy link
Member

@wheeheee wheeheee commented Feb 5, 2024

also added CODECOV_TOKEN Dependabot repository secret

also added CODECOV_TOKEN dependabot repository secret
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c6f4fa) 97.29% compared to head (9dd734f) 97.46%.
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
+ Coverage   97.29%   97.46%   +0.17%     
==========================================
  Files          18       18              
  Lines        3105     3080      -25     
==========================================
- Hits         3021     3002      -19     
+ Misses         84       78       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wheeheee
Copy link
Member Author

wheeheee commented Feb 5, 2024

Do we want CI to fail if the Codecov upload errors?
I could add fail_ci_if_error: true if this is desired.

@ViralBShah
Copy link
Contributor

I don't think we want CI to fail in case codecov upload errors. Let's see how it works out for the foreseeable future, and if we need to be more strict.

@ViralBShah ViralBShah merged commit 1de670c into JuliaDSP:master Feb 5, 2024
11 checks passed
@wheeheee wheeheee deleted the token branch February 5, 2024 09:15
@ViralBShah
Copy link
Contributor

It seems that the general consensus is that we should use fail_ci_if_error: true. @wheeheee would you be able to add that in a new PR? Sorry for setting you on the wrong path here.

@wheeheee wheeheee added the no changelog Prevent TagBot from inclusion in release notes label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Prevent TagBot from inclusion in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants