Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail ci with codecov error + workflow_dispatch #528

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

wheeheee
Copy link
Member

@wheeheee wheeheee commented Feb 6, 2024

  • fail_ci_if_error: true => if the codecov upload errors, CI fails (probably due to secrets / codecov token)
  • manually triggering CI is enabled with workflow_dispatch

Following up on #525.
On a side note, Windows on v1.6 is taking up a lot of time on julia-buildpkg.

- `fail_ci_if_error: true` => if the codecov upload errors, CI fails (probably due to secrets / codecov token)
- manually triggering CI is enabled with `workflow_dispatch`
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2637592) 97.46% compared to head (6da298b) 97.46%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #528   +/-   ##
=======================================
  Coverage   97.46%   97.46%           
=======================================
  Files          18       18           
  Lines        3080     3080           
=======================================
  Hits         3002     3002           
  Misses         78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah
Copy link
Contributor

Yeah, not sure what to do about the 1.6 windows build being so slow. Hopefully we will have a new LTS very soon.

@ViralBShah
Copy link
Contributor

@DilumAluthge Any ideas why 1.6 on windows is so slow and is there any obvious quick thing we can do on the CI side?

@DilumAluthge
Copy link

Hmmm. 6 minutes to download the cache, but then 6 more minutes in buildpkg? That's a bit odd. You could try commenting out the caching.

I'm also wondering why the General registry is getting cloned over Git; we should be using the Pkg server instead.

@IanButterworth @omus any ideas on the caching?

@ViralBShah ViralBShah merged commit 1c519ce into JuliaDSP:master Feb 6, 2024
11 checks passed
@wheeheee wheeheee deleted the ci branch February 6, 2024 04:37
@wheeheee
Copy link
Member Author

wheeheee commented Feb 6, 2024

Just a note that the coverage upload may randomly fail. Maybe Codecov is getting too popular, or v4 teething troubles?

@IanButterworth
Copy link

I can't remember the behavior of using the pkgserver on 1.6 but it might not by default on windows?

JuliaLang/Pkg.jl#2377

@wheeheee wheeheee added the no changelog Prevent TagBot from inclusion in release notes label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Prevent TagBot from inclusion in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants