-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yota support #50
base: master
Are you sure you want to change the base?
Yota support #50
Conversation
I see one error coming from a Yota bug that is already fixed on
Do you have a minimal code example that reproduces them? If not, give me a couple of days to learn internals of AbstractDifferentiation and find where the problem comes from. |
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
- Coverage 83.36% 78.21% -5.16%
==========================================
Files 6 6
Lines 475 358 -117
==========================================
- Hits 396 280 -116
+ Misses 79 78 -1
Continue to review full report at Codecov.
|
Unfortunately no. I can dig into it next week if you don't beat me to it (please do :)). |
I managed to fix a few cases, but the amount of errors only grows, and I don't understand the code base here well enough to understand what exactly is expected. Is there a minimal set of interfaces that need to be implemented? Perhaps, |
Some of the internals here will be redesigned soon so I would wait for that to happen before trying to understand them :) |
This PR is based on #49 but tests here fail. I am opening it in case @dfdx or someone else can figure out why they fail when Zygote passes.