Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in evaluate and pow #369

Merged
merged 9 commits into from
Jan 23, 2025
Merged

Fixes in evaluate and pow #369

merged 9 commits into from
Jan 23, 2025

Conversation

lbenet
Copy link
Member

@lbenet lbenet commented Aug 29, 2024

No description provided.

@lbenet
Copy link
Member Author

lbenet commented Jan 23, 2025

This PR reduces marginally some allocations when using pow or ^, in some cases reaching 10% of improvement. It also solves an issue appearing in TaylorModels with pow. Tests pass, so I merge this.

As a side comment, I note a dramatic performance hit from v1.10 to v1.11...

@lbenet lbenet merged commit 84a007f into master Jan 23, 2025
14 checks passed
@lbenet lbenet deleted the lb/_pow branch January 23, 2025 18:39
@PerezHz
Copy link
Contributor

PerezHz commented Jan 23, 2025

This PR reduces marginally some allocations when using pow or ^, in some cases reaching 10% of improvement. It also solves an issue appearing in TaylorModels with pow. Tests pass, so I merge this.

This PR looks pretty neat! Just o try to understand it better, did you find allocations happening in pow!? Or were the allocations coming from pow (without bang !)?

@lbenet
Copy link
Member Author

lbenet commented Jan 23, 2025

I think it was some sort of type unstability somewhere in the mess of pow, and some small fixes in pow!. But I see no dramatic improvements in time.

@lbenet
Copy link
Member Author

lbenet commented Jan 24, 2025

@PerezHz @LuEdRaMo I didn't check the consequences on NEOs.jl or PlanetaryEphemeris.jl; can you check it? (Though it's a bit late, I could revert the merge commit...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants