Properly skip EnumForwardDecls
even with attributes
#522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacOS ObjectiveC headers have enum forward declarations with attributes.
Currently, such a node gets marked as skip during
CodegenPreprocessing
:Clang.jl/src/generator/passes.jl
Lines 632 to 638 in 572eddf
but then it immediately gets replaced with an EnumLayout due to the next check checking the original node:
Clang.jl/src/generator/passes.jl
Lines 639 to 644 in 572eddf
I'm not sure if my fix is the intended behaviour, so it would be nice to have someone review it. Other solutions I consedered were adding a
continue
to the end of each check (or only toskip_check
), or maybe instead of doing checks on the original node, always check the newest.Includes changes from #519.